Skip to content

[Enhancement] aws_sagemaker_space: Add space_settings.remote_access argument #44567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Enhancement] aws_sagemaker_space: Add space_settings.remote_access argument #44567

wants to merge 4 commits into from
+100 −0

Conversation

tabito-hara
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

  • Add space_settings.remote_access argument for aws_sagemaker_space

Relations

Closes #44553

References

https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_SpaceSettings.html#sagemaker-Type-SpaceSettings-RemoteAccess

Output from Acceptance Testing

$ make testacc TESTS='TestAccSageMaker_serial/Space' PKG=sagemaker 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿  f-aws_sagemaker_space-add_remote_access 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMaker_serial/Space'  -timeout 360m -vet=off
2025/10/07 09:21:16 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/07 09:21:16 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/Space
=== RUN   TestAccSageMaker_serial/Space/basic
=== RUN   TestAccSageMaker_serial/Space/disappears
=== RUN   TestAccSageMaker_serial/Space/tags
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings
=== RUN   TestAccSageMaker_serial/Space/jupyterServerAppSettings
=== RUN   TestAccSageMaker_serial/Space/jupyterLabAppSettings
=== RUN   TestAccSageMaker_serial/Space/jupyterLabAppSettingsLifecycle
=== RUN   TestAccSageMaker_serial/Space/codeEditorAppSettings
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings_lifecycleConfig
=== RUN   TestAccSageMaker_serial/Space/kernelGatewayAppSettings_imageConfig
    space_test.go:204: Environment variable SAGEMAKER_IMAGE_VERSION_BASE_IMAGE is not set
=== RUN   TestAccSageMaker_serial/Space/storageSettings
=== RUN   TestAccSageMaker_serial/Space/customFileSystem
=== RUN   TestAccSageMaker_serial/Space/remoteAccess
--- PASS: TestAccSageMaker_serial (2707.55s)
    --- PASS: TestAccSageMaker_serial/Space (2707.55s)
        --- PASS: TestAccSageMaker_serial/Space/basic (214.46s)
        --- PASS: TestAccSageMaker_serial/Space/disappears (205.63s)
        --- PASS: TestAccSageMaker_serial/Space/tags (238.35s)
        --- PASS: TestAccSageMaker_serial/Space/kernelGatewayAppSettings (204.62s)
        --- PASS: TestAccSageMaker_serial/Space/jupyterServerAppSettings (206.15s)
        --- PASS: TestAccSageMaker_serial/Space/jupyterLabAppSettings (220.55s)
        --- PASS: TestAccSageMaker_serial/Space/jupyterLabAppSettingsLifecycle (224.14s)
        --- PASS: TestAccSageMaker_serial/Space/codeEditorAppSettings (224.88s)
        --- PASS: TestAccSageMaker_serial/Space/kernelGatewayAppSettings_lifecycleConfig (212.46s)
        --- SKIP: TestAccSageMaker_serial/Space/kernelGatewayAppSettings_imageConfig (0.00s)
        --- PASS: TestAccSageMaker_serial/Space/storageSettings (220.07s)
        --- PASS: TestAccSageMaker_serial/Space/customFileSystem (314.25s)
        --- PASS: TestAccSageMaker_serial/Space/remoteAccess (221.98s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  2711.785s

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. labels Oct 7, 2025
@tabito-hara tabito-hara force-pushed the f-aws_sagemaker_space-add_remote_access branch from 8f14848 to 45c76c2 Compare October 7, 2025 12:15
@tabito-hara tabito-hara marked this pull request as ready for review October 7, 2025 13:23
@tabito-hara tabito-hara requested a review from a team as a code owner October 7, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add remote_access_enabled boolean argument to aws_sagemaker_space
1 participant
@tabito-hara